垃圾代码书写准则
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

274 lines
4.6 KiB

5 years ago
# State-of-the-Art Shitcode Principles
5 years ago
[![State-of-the-art Shitcode](https://img.shields.io/static/v1?label=State-of-the-art&message=Shitcode&color=7B5804)](https://github.com/trekhleb/state-of-the-art-shitcode)
5 years ago
This a list of state-of-the-art shitcode principles your project should follow.
5 years ago
## Get Your Badge
5 years ago
5 years ago
If your repository follows the state-of-the-art shitcode principles you may use the following "state-of-the-art shitcode" badge:
5 years ago
```
5 years ago
[![State-of-the-art Shitcode](https://img.shields.io/static/v1?label=State-of-the-art&message=Shitcode&color=7B5804)](https://github.com/trekhleb/state-of-the-art-shitcode)
5 years ago
```
5 years ago
## The Principles
5 years ago
### 💩 Name variables in a way as if your code was already obfuscated
5 years ago
5 years ago
Less keystrokes, more time for you.
5 years ago
_Good 👍🏻_
5 years ago
5 years ago
```javascript
5 years ago
let a = 42;
```
5 years ago
_Bad 👎🏻_
5 years ago
5 years ago
```javascript
5 years ago
let age = 42;
5 years ago
```
5 years ago
### 💩 Mix variable/functions naming style
Celebrate the difference.
5 years ago
_Good 👍🏻_
5 years ago
```javascript
let wWidth = 640;
let w_height = 480;
```
5 years ago
_Bad 👎🏻_
5 years ago
```javascript
let windowWidth = 640;
let windowHeight = 480;
```
### 💩 Never write comments
5 years ago
No one is going to read your code anyway.
5 years ago
5 years ago
_Good 👍🏻_
5 years ago
```javascript
const cdr = 700;
```
5 years ago
_Bad 👎🏻_
5 years ago
```javascript
// Callback function debounce rate in milliseconds.
const callbackDebounceRate = 700;
```
5 years ago
### 💩 Always write comments in your native language
5 years ago
5 years ago
If you violated the "No comments" principle then at least try to write comments in a language that is different from the language you use to write the code. If your native language is English you may violate this principle.
5 years ago
5 years ago
_Good 👍🏻_
5 years ago
```javascript
5 years ago
// Закриваємо модальне віконечко при виникненні помилки.
toggleModal(false);
5 years ago
```
5 years ago
_Bad 👎🏻_
5 years ago
```javascript
5 years ago
// Hide modal window on error.
toggleModal(false);
5 years ago
```
### 💩 Try to mix formatting style as much as possible
Celebrate the difference.
_Good 👍🏻_
```javascript
let i = ['tomato', 'onion', 'mushrooms'];
let d = [ "ketchup", "mayonnaise" ];
```
_Bad 👎🏻_
```javascript
let ingredients = ['tomato', 'onion', 'mushrooms'];
let dressings = ['ketchup', 'mayonnaise'];
```
### 💩 Put as much code as possible into one line
_Good 👍🏻_
```javascript
document.location.search.replace(/(^\?)/,'').split('&').reduce(function(o,n){n=n.split('=');o[n[0]]=n[1];return o},{})
```
_Bad 👎🏻_
```javascript
document.location.search
.replace(/(^\?)/, '')
.split('&')
.reduce((searchParams, keyValuePair) => {
keyValuePair = keyValuePair.split('=');
searchParams[keyValuePair[0]] = keyValuePair[1];
return searchParams;
},
{}
)
```
### 💩 Fail silently
Whenever you catch an error it is not necessary for anyone to know about it. No logs, no error modals, chill.
_Good 👍🏻_
```javascript
try {
// Something unpredictable.
} catch (error) {
// tss... 🤫
}
```
_Bad 👎🏻_
```javascript
try {
// Something unpredictable.
} catch (error) {
setErrorMessage(error.message);
// and/or
logError(error);
}
```
### 💩 Use global variables extensively
Globalization principle.
_Good 👍🏻_
```javascript
let x = 5;
function square() {
x = x ** 2;
}
square(); // Now x is 25.
```
_Bad 👎🏻_
```javascript
let x = 5;
function square(num) {
return num ** 2;
}
x = square(x); // Now x is 25.
```
### 💩 Create variables that you're not going to use.
Just in case.
_Good 👍🏻_
```javascript
function sum(a, b, c) {
const timeout = 1300;
const result = a + b;
return a + b;
}
```
_Bad 👎🏻_
```javascript
function sum(a, b) {
return a + b;
}
```
### 💩 Triangle principle
Be like a bird - nest, nest, nest.
_Good 👍🏻_
```javascript
function someFunction() {
if (condition1) {
if (condition2) {
asyncFunction(params, (result) => {
if (result) {
for (;;) {
if (condition3) {
}
}
}
})
}
}
}
```
_Bad 👎🏻_
```javascript
async function someFunction() {
if (!condition1 || !condition2) {
return;
}
const result = await asyncFunction(params);
if (!result) {
return;
}
for (;;) {
if (condition3) {
}
}
}
```
### 💩 Do not lock your dependencies
Update your dependencies on each new installation in uncontrolled way. Why stick to the past, let's use the cutting edge libraries versions.
_Good 👍🏻_
```
$ ls -la
package.json
```
_Bad 👎🏻_
```
$ ls -la
package.json
package-lock.json
```
### 💩 Avoid covering your code with tests
This is a duplicate and unnecessary amount of work.
### 💩 Start your project without a README file.
And keep it that way for the time being.