Browse Source

fix: Table filter throw react warning (#43139)

pull/43144/head
二货爱吃白萝卜 1 year ago
committed by GitHub
parent
commit
ec29ebf2c9
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 2
      components/table/__tests__/Table.filter.test.tsx
  2. 19
      components/table/hooks/useFilter/FilterWrapper.tsx

2
components/table/__tests__/Table.filter.test.tsx

@ -134,6 +134,8 @@ describe('Table.filter', () => {
});
it('renders empty menu correctly', () => {
resetWarned();
const errorSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
const { container } = render(
createTable({

19
components/table/hooks/useFilter/FilterWrapper.tsx

@ -13,10 +13,21 @@ const onKeyDown: React.KeyboardEventHandler<HTMLDivElement> = (event) => {
}
};
const FilterDropdownMenuWrapper: React.FC<FilterDropdownMenuWrapperProps> = (props) => (
<div className={props.className} onClick={(e) => e.stopPropagation()} onKeyDown={onKeyDown}>
{props.children}
</div>
const FilterDropdownMenuWrapper = React.forwardRef<HTMLDivElement, FilterDropdownMenuWrapperProps>(
(props, ref) => (
<div
className={props.className}
onClick={(e) => e.stopPropagation()}
onKeyDown={onKeyDown}
ref={ref}
>
{props.children}
</div>
),
);
if (process.env.NODE_ENV !== 'production') {
FilterDropdownMenuWrapper.displayName = 'FilterDropdownMenuWrapper';
}
export default FilterDropdownMenuWrapper;

Loading…
Cancel
Save