Browse Source

Fix Table pagination.onChange arguments

react-component/pagination#58
pull/4939/head
afc163 8 years ago
parent
commit
b34557ef17
  1. 4
      components/table/Table.tsx
  2. 7
      components/table/__tests__/Table.pagination.test.js

4
components/table/Table.tsx

@ -500,7 +500,7 @@ export default class Table<T> extends React.Component<TableProps<T>, any> {
});
}
handlePageChange = (current) => {
handlePageChange = (current, ...otherArguments) => {
const props = this.props;
let pagination = assign({}, this.state.pagination);
if (current) {
@ -508,7 +508,7 @@ export default class Table<T> extends React.Component<TableProps<T>, any> {
} else {
pagination.current = pagination.current || 1;
}
pagination.onChange(pagination.current);
pagination.onChange(pagination.current, ...otherArguments);
const newState = {
pagination,

7
components/table/__tests__/Table.pagination.test.js

@ -56,9 +56,10 @@ describe('Table.pagination', () => {
it('fires change event', () => {
const handleChange = jest.fn();
const handlePaginationChange = jest.fn();
const noop = () => {};
const wrapper = mount(createTable({
pagination: { ...pagination, onChange: noop, onShowSizeChange: noop },
pagination: { ...pagination, onChange: handlePaginationChange, onShowSizeChange: noop },
onChange: handleChange,
}));
@ -67,13 +68,15 @@ describe('Table.pagination', () => {
expect(handleChange).toBeCalledWith(
{
current: 2,
onChange: noop,
onChange: handlePaginationChange,
onShowSizeChange: noop,
pageSize: 2,
},
{},
{}
);
expect(handlePaginationChange).toBeCalledWith(2, 2);
});
// https://github.com/ant-design/ant-design/issues/4532

Loading…
Cancel
Save