Merge pull request #17756 from ant-design/fix-cascader

fix: Cascader broken when option children is null

components/cascader/__tests__/index.test.js

@@ -451,4 +451,24 @@ describe('Cascader', () => {
     );
     errorSpy.mockRestore();
   });
+
+  // https://github.com/ant-design/ant-design/issues/17690
+  it('should not breaks when children is null', () => {
+    const optionsWithChildrenNull = [
+      {
+        value: 'zhejiang',
+        label: 'Zhejiang',
+        children: [
+          {
+            value: 'hangzhou',
+            label: 'Hangzhou',
+            children: null,
+          },
+        ],
+      },
+    ];
+    expect(() => {
+      mount(<Cascader options={optionsWithChildrenNull} />);
+    }).not.toThrow();
+  });
 });

components/cascader/index.tsx

@@ -206,8 +206,8 @@ function flattenTree(
 
 const defaultDisplayRender = (label: string[]) => label.join(' / ');
 
-function warningValueNotExist(list: CascaderOptionType[] = [], fieldNames: FieldNamesType = {}) {
-  list.forEach(item => {
+function warningValueNotExist(list: CascaderOptionType[], fieldNames: FieldNamesType = {}) {
+  (list || []).forEach(item => {
     const valueFieldName = fieldNames.value || 'value';
     warning(valueFieldName in item, 'Cascader', 'Not found `value` in `options`.');
     warningValueNotExist(item[fieldNames.children || 'children'], fieldNames);