Browse Source

refactor(skeleton): rewrite with hook (#23206)

* refactor(skeleton): rewrite with hook

* fix(skeleton): refine lint and compile issues

* fix(skeleton): refine compile issues

* chore: ignore eslint warning
pull/23218/head
Rustin 5 years ago
committed by GitHub
parent
commit
13fda44fb1
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 1
      .antd-tools.config.js
  2. 24
      components/skeleton/Avatar.tsx
  3. 24
      components/skeleton/Button.tsx
  4. 10
      components/skeleton/Element.tsx
  5. 24
      components/skeleton/Input.tsx
  6. 17
      components/skeleton/Paragraph.tsx
  7. 40
      components/skeleton/Skeleton.tsx
  8. 6
      components/skeleton/index.tsx

1
.antd-tools.config.js

@ -104,6 +104,7 @@ function finalizeDist() {
path.join(process.cwd(), 'dist', 'theme.js'),
`const defaultTheme = require('./default-theme.js');\n`,
);
// eslint-disable-next-line no-console
console.log('Built a entry less file to dist/antd.less');
buildThemeFile('default', defaultVars);
buildThemeFile('dark', darkVars);

24
components/skeleton/Avatar.tsx

@ -8,17 +8,11 @@ export interface AvatarProps extends Omit<SkeletonElementProps, 'shape'> {
shape?: 'circle' | 'square';
}
// eslint-disable-next-line react/prefer-stateless-function
class SkeletonAvatar extends React.Component<AvatarProps, any> {
static defaultProps: Partial<AvatarProps> = {
size: 'default',
shape: 'circle',
};
renderSkeletonAvatar = ({ getPrefixCls }: ConfigConsumerProps) => {
const { prefixCls: customizePrefixCls, className, active } = this.props;
const SkeletonAvatar = (props: AvatarProps) => {
const renderSkeletonAvatar = ({ getPrefixCls }: ConfigConsumerProps) => {
const { prefixCls: customizePrefixCls, className, active } = props;
const prefixCls = getPrefixCls('skeleton', customizePrefixCls);
const otherProps = omit(this.props, ['prefixCls']);
const otherProps = omit(props, ['prefixCls']);
const cls = classNames(prefixCls, className, `${prefixCls}-element`, {
[`${prefixCls}-active`]: active,
});
@ -28,10 +22,12 @@ class SkeletonAvatar extends React.Component<AvatarProps, any> {
</div>
);
};
render() {
return <ConfigConsumer>{this.renderSkeletonAvatar}</ConfigConsumer>;
}
return <ConfigConsumer>{renderSkeletonAvatar}</ConfigConsumer>;
}
SkeletonAvatar.defaultProps = {
size: 'default',
shape: 'circle',
};
export default SkeletonAvatar;

24
components/skeleton/Button.tsx

@ -4,20 +4,15 @@ import classNames from 'classnames';
import Element, { SkeletonElementProps } from './Element';
import { ConfigConsumer, ConfigConsumerProps } from '../config-provider';
interface SkeletonButtonProps extends Omit<SkeletonElementProps, 'size'> {
export interface SkeletonButtonProps extends Omit<SkeletonElementProps, 'size'> {
size?: 'large' | 'small' | 'default';
}
// eslint-disable-next-line react/prefer-stateless-function
class SkeletonButton extends React.Component<SkeletonButtonProps, any> {
static defaultProps: Partial<SkeletonButtonProps> = {
size: 'default',
};
renderSkeletonButton = ({ getPrefixCls }: ConfigConsumerProps) => {
const { prefixCls: customizePrefixCls, className, active } = this.props;
const SkeletonButton = (props: SkeletonButtonProps) => {
const renderSkeletonButton = ({ getPrefixCls }: ConfigConsumerProps) => {
const { prefixCls: customizePrefixCls, className, active } = props;
const prefixCls = getPrefixCls('skeleton', customizePrefixCls);
const otherProps = omit(this.props, ['prefixCls']);
const otherProps = omit(props, ['prefixCls']);
const cls = classNames(prefixCls, className, `${prefixCls}-element`, {
[`${prefixCls}-active`]: active,
});
@ -27,10 +22,11 @@ class SkeletonButton extends React.Component<SkeletonButtonProps, any> {
</div>
);
};
return <ConfigConsumer>{renderSkeletonButton}</ConfigConsumer>;
};
render() {
return <ConfigConsumer>{this.renderSkeletonButton}</ConfigConsumer>;
}
}
SkeletonButton.defaultProps = {
size: 'default',
};
export default SkeletonButton;

10
components/skeleton/Element.tsx

@ -10,10 +10,8 @@ export interface SkeletonElementProps {
active?: boolean;
}
// eslint-disable-next-line react/prefer-stateless-function
class Element extends React.Component<SkeletonElementProps, any> {
render() {
const { prefixCls, className, style, size, shape } = this.props;
const Element = (props: SkeletonElementProps) => {
const { prefixCls, className, style, size, shape } = props;
const sizeCls = classNames({
[`${prefixCls}-lg`]: size === 'large',
@ -40,7 +38,7 @@ class Element extends React.Component<SkeletonElementProps, any> {
style={{ ...sizeStyle, ...style }}
/>
);
}
}
};
export default Element;

24
components/skeleton/Input.tsx

@ -4,20 +4,15 @@ import classNames from 'classnames';
import Element, { SkeletonElementProps } from './Element';
import { ConfigConsumer, ConfigConsumerProps } from '../config-provider';
interface SkeletonInputProps extends Omit<SkeletonElementProps, 'size' | 'shape'> {
export interface SkeletonInputProps extends Omit<SkeletonElementProps, 'size' | 'shape'> {
size?: 'large' | 'small' | 'default';
}
// eslint-disable-next-line react/prefer-stateless-function
class SkeletonInput extends React.Component<SkeletonInputProps, any> {
static defaultProps: Partial<SkeletonInputProps> = {
size: 'default',
};
renderSkeletonInput = ({ getPrefixCls }: ConfigConsumerProps) => {
const { prefixCls: customizePrefixCls, className, active } = this.props;
const SkeletonInput = (props: SkeletonInputProps) => {
const renderSkeletonInput = ({ getPrefixCls }: ConfigConsumerProps) => {
const { prefixCls: customizePrefixCls, className, active } = props;
const prefixCls = getPrefixCls('skeleton', customizePrefixCls);
const otherProps = omit(this.props, ['prefixCls']);
const otherProps = omit(props, ['prefixCls']);
const cls = classNames(prefixCls, className, `${prefixCls}-element`, {
[`${prefixCls}-active`]: active,
});
@ -27,10 +22,11 @@ class SkeletonInput extends React.Component<SkeletonInputProps, any> {
</div>
);
};
return <ConfigConsumer>{renderSkeletonInput}</ConfigConsumer>;
};
render() {
return <ConfigConsumer>{this.renderSkeletonInput}</ConfigConsumer>;
}
}
SkeletonInput.defaultProps = {
size: 'default',
};
export default SkeletonInput;

17
components/skeleton/Paragraph.tsx

@ -11,9 +11,9 @@ export interface SkeletonParagraphProps {
rows?: number;
}
class Paragraph extends React.Component<SkeletonParagraphProps, {}> {
getWidth(index: number) {
const { width, rows = 2 } = this.props;
const Paragraph = (props: SkeletonParagraphProps) => {
const getWidth = (index: number) => {
const { width, rows = 2 } = props;
if (Array.isArray(width)) {
return width[index];
}
@ -22,20 +22,17 @@ class Paragraph extends React.Component<SkeletonParagraphProps, {}> {
return width;
}
return undefined;
}
render() {
const { prefixCls, className, style, rows } = this.props;
};
const { prefixCls, className, style, rows } = props;
const rowList = [...Array(rows)].map((_, index) => (
// eslint-disable-next-line react/no-array-index-key
<li key={index} style={{ width: this.getWidth(index) }} />
<li key={index} style={{ width: getWidth(index) }}/>
));
return (
<ul className={classNames(prefixCls, className)} style={style}>
{rowList}
</ul>
);
}
}
};
export default Paragraph;

40
components/skeleton/Skeleton.tsx

@ -3,13 +3,14 @@ import classNames from 'classnames';
import Title, { SkeletonTitleProps } from './Title';
import Paragraph, { SkeletonParagraphProps } from './Paragraph';
import { ConfigConsumer, ConfigConsumerProps } from '../config-provider';
import SkeletonButton from './Button';
import Element from './Element';
import SkeletonAvatar, { AvatarProps } from './Avatar';
import SkeletonButton from './Button';
import SkeletonInput from './Input';
/* This only for skeleton internal. */
interface SkeletonAvatarProps extends Omit<AvatarProps, 'active'> {}
interface SkeletonAvatarProps extends Omit<AvatarProps, 'active'> {
}
export interface SkeletonProps {
active?: boolean;
@ -68,20 +69,8 @@ function getParagraphBasicProps(hasAvatar: boolean, hasTitle: boolean): Skeleton
return basicProps;
}
class Skeleton extends React.Component<SkeletonProps, any> {
static Button: typeof SkeletonButton;
static Avatar: typeof SkeletonAvatar;
static Input: typeof SkeletonInput;
static defaultProps: Partial<SkeletonProps> = {
avatar: false,
title: true,
paragraph: true,
};
renderSkeleton = ({ getPrefixCls, direction }: ConfigConsumerProps) => {
const Skeleton = (props: SkeletonProps) => {
const renderSkeleton = ({ getPrefixCls, direction }: ConfigConsumerProps) => {
const {
prefixCls: customizePrefixCls,
loading,
@ -91,11 +80,11 @@ class Skeleton extends React.Component<SkeletonProps, any> {
title,
paragraph,
active,
} = this.props;
} = props;
const prefixCls = getPrefixCls('skeleton', customizePrefixCls);
if (loading || !('loading' in this.props)) {
if (loading || !('loading' in props)) {
const hasAvatar = !!avatar;
const hasTitle = !!title;
const hasParagraph = !!paragraph;
@ -166,10 +155,17 @@ class Skeleton extends React.Component<SkeletonProps, any> {
return children;
};
return <ConfigConsumer>{renderSkeleton}</ConfigConsumer>;
};
render() {
return <ConfigConsumer>{this.renderSkeleton}</ConfigConsumer>;
}
}
Skeleton.defaultProps = {
avatar: false,
title: true,
paragraph: true,
};
Skeleton.Button = SkeletonButton;
Skeleton.Avatar = SkeletonAvatar;
Skeleton.Input = SkeletonInput;
export default Skeleton;

6
components/skeleton/index.tsx

@ -1,11 +1,5 @@
import Skeleton from './Skeleton';
import SkeletonButton from './Button';
import SkeletonAvatar from './Avatar';
import SkeletonInput from './Input';
export { SkeletonProps } from './Skeleton';
Skeleton.Button = SkeletonButton;
Skeleton.Avatar = SkeletonAvatar;
Skeleton.Input = SkeletonInput;
export default Skeleton;

Loading…
Cancel
Save