From 0bcad13bb3c61037e82a19c8cd3a8dbaf7b4b0d0 Mon Sep 17 00:00:00 2001 From: Chris Fritz Date: Tue, 7 Mar 2017 21:18:02 -0500 Subject: [PATCH] Reorganize and update PR template (#5106) * Reorganize and update PR template * Update PULL_REQUEST_TEMPLATE.md * Remove required info for bugfixes --- .github/PULL_REQUEST_TEMPLATE.md | 65 +++++++++++++++----------------- 1 file changed, 30 insertions(+), 35 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7ec69e62..7bda0561 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -3,38 +3,33 @@ Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> - -**Please check if the PR fulfills these requirements** -- [ ] Do not submit PRs against the master branch. -- [ ] Checkout a topic branch from the relevant branch, e.g. dev, and merge back against that branch. -- [ ] The tests are running: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup - -If adding new feature: -- [ ] Added accompanying test case. -- [ ] In the commit message, provide convincing reason to add this feature. - Ideally you should open a suggestion issue first and have it greenlighted before working on it. - -If fixing a bug: -- [ ] If you are resolving a special issue, add (fix #xxxx[,#xxx]) (#xxxx is the issue id) in your PR title -- [ ] Provide detailed description of the bug in the PR. Live demo preferred. -- [ ] Add appropriate test coverage if applicable. - -**What kind of change does this PR introduce?** (check at least one with "x") -``` -[ ] Bugfix -[ ] Feature -[ ] Code style update -[ ] Refactoring -[ ] Build related changes -[ ] Other... Please describe: -``` - -**Does this PR introduce a breaking change?** (check one with "x") -``` -[ ] Yes -[ ] No -``` - -If this PR contains a breaking change, please describe the impact and migration path for existing applications: - -**Other information**: + + + +**What kind of change does this PR introduce?** (check at least one) + +- [ ] Bugfix +- [ ] Feature +- [ ] Code style update +- [ ] Refactor +- [ ] Build-related changes +- [ ] Other, please describe: + +**Does this PR introduce a breaking change?** (check one) + +- [ ] Yes +- [ ] No + +If yes, please describe the impact and migration path for existing applications: + +**The PR fulfills these requirements:** + +- [ ] It's submitted to the `dev` branch for v2.x (or to a previous version branch), _not_ the `master` branch +- [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix #xxx[,#xxx]`, where "xxx" is the issue number) +- [ ] All tests are passing: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup +- [ ] New/updated tests are included + +If adding a **new feature**, the PR's description includes: +- [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it) + +**Other information:**